From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END} Date: Mon, 09 Mar 2026 09:08:52 +1000 Message-ID: In-Reply-To: <20260306062805.1464383-2-xry111@xry111.site> References: <20260306062805.1464383-2-xry111@xry111.site> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Wrap dcn32_override_min_req_memclk() in DC_FP_{START, END} Author: Xi Ruoyao Patches: 1 Reviewed: 2026-03-09T09:08:52.939278 --- This is a single-patch series that fixes a missing FP context save/restore around a call to `dcn32_override_min_req_memclk()`. The function lives in `dcn32_fpu.c`, which is compiled with `CC_FLAGS_FPU` (enabling FP instructions). On architectures like LoongArch where the FPU isn't always enabled, calling into FPU-compiled code without the proper `DC_FP_START()`/`DC_FP_END()` guards will cause faults or incorrect behavior. The fix is correct, minimal, and follows the established pattern already used throughout the same file (e.g., the `dcn32_internal_validate_bw()` call at lines 1770-1771 uses the same `DC_FP_START/END` wrapping). The `Fixes:` tag and `Cc: stable` are appropriate since this is a real bug that affects users on LoongArch. **Verdict: Good to merge.** --- Generated by Claude Code Patch Reviewer