From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sysfb: efidrm: Fix framebuffer mapping error handling
Date: Mon, 09 Mar 2026 09:07:28 +1000 [thread overview]
Message-ID: <review-overall-20260306091927.1934860-1-nichen@iscas.ac.cn> (raw)
In-Reply-To: <20260306091927.1934860-1-nichen@iscas.ac.cn>
Overall Series Review
Subject: drm/sysfb: efidrm: Fix framebuffer mapping error handling
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 1
Reviewed: 2026-03-09T09:07:28.386548
---
This is a single-patch fix for the `efidrm` driver addressing two real bugs in framebuffer mapping error handling:
1. **Incorrect error check for `devm_memremap()`**: The original code used `!screen_base` (NULL check) but `devm_memremap()` returns an `ERR_PTR` on failure, not NULL. This is a genuine bug.
2. **Wrong `iosys_map` type for system memory**: The original code passed `devm_memremap()` results (plain `void *`) to `iosys_map_set_vaddr_iomem()`, which expects `void __iomem *`. The fix correctly distinguishes between I/O memory and system memory mappings.
The fix also improves the `else` branch (invalid mem_flags) by returning an error instead of falling through to a NULL check.
Overall the patch is correct and addresses real issues. There is one type-safety concern worth noting.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:19 [PATCH] drm/sysfb: efidrm: Fix framebuffer mapping error handling Chen Ni
2026-03-08 23:07 ` Claude review: " Claude Code Review Bot
2026-03-08 23:07 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306091927.1934860-1-nichen@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox