From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sysfb: efidrm: Fix framebuffer mapping error handling Date: Mon, 09 Mar 2026 09:07:28 +1000 Message-ID: In-Reply-To: <20260306091927.1934860-1-nichen@iscas.ac.cn> References: <20260306091927.1934860-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/sysfb: efidrm: Fix framebuffer mapping error handling Author: Chen Ni Patches: 1 Reviewed: 2026-03-09T09:07:28.386548 --- This is a single-patch fix for the `efidrm` driver addressing two real bugs in framebuffer mapping error handling: 1. **Incorrect error check for `devm_memremap()`**: The original code used `!screen_base` (NULL check) but `devm_memremap()` returns an `ERR_PTR` on failure, not NULL. This is a genuine bug. 2. **Wrong `iosys_map` type for system memory**: The original code passed `devm_memremap()` results (plain `void *`) to `iosys_map_set_vaddr_iomem()`, which expects `void __iomem *`. The fix correctly distinguishes between I/O memory and system memory mappings. The fix also improves the `else` branch (invalid mem_flags) by returning an error instead of falling through to a NULL check. Overall the patch is correct and addresses real issues. There is one type-safety concern worth noting. --- Generated by Claude Code Patch Reviewer