From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: remove bpc > 8 entries from allow list
Date: Mon, 09 Mar 2026 09:06:15 +1000 [thread overview]
Message-ID: <review-overall-20260306092518.37849-1-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260306092518.37849-1-mitltlatltl@gmail.com>
Overall Series Review
Subject: drm/msm/dsi: remove bpc > 8 entries from allow list
Author: Pengyu Luo <mitltlatltl@gmail.com>
Patches: 5
Reviewed: 2026-03-09T09:06:15.193451
---
This is a single patch that removes `case 10:` and `case 12:` from the `bits_per_component` allow list in `dsi_populate_dsc_params()`, restricting DSC to 8 bpc only. The stated rationale is that bpc > 8 is "not supported yet" in upstream MSM.
The patch is **questionable in its motivation and correctness**. The code path for 10/12 bpc appears to be fully functional — the RC parameters tables (`rc_parameters_pre_scr`) in `drm_dsc_helper.c` have entries for bpc=10, and the rest of `dsi_populate_dsc_params()` is generic with respect to bpc. The original commit `b0e71c2637d1` deliberately added 10/12 bpc support. Removing it without a clear bug report or test failure constitutes a functionality regression.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:25 [PATCH] drm/msm/dsi: remove bpc > 8 entries from allow list Pengyu Luo
2026-03-06 18:47 ` Dmitry Baryshkov
2026-03-06 19:56 ` Eugene Lepshy
2026-03-06 20:19 ` Евгений Лепший
2026-03-07 6:37 ` Pengyu Luo
2026-03-08 23:06 ` Claude Code Review Bot [this message]
2026-03-08 23:06 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306092518.37849-1-mitltlatltl@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox