From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: remove bpc > 8 entries from allow list Date: Mon, 09 Mar 2026 09:06:15 +1000 Message-ID: In-Reply-To: <20260306092518.37849-1-mitltlatltl@gmail.com> References: <20260306092518.37849-1-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dsi: remove bpc > 8 entries from allow list Author: Pengyu Luo Patches: 5 Reviewed: 2026-03-09T09:06:15.193451 --- This is a single patch that removes `case 10:` and `case 12:` from the `bit= s_per_component` allow list in `dsi_populate_dsc_params()`, restricting DSC= to 8 bpc only. The stated rationale is that bpc > 8 is "not supported yet"= in upstream MSM. The patch is **questionable in its motivation and correctness**. The code p= ath for 10/12 bpc appears to be fully functional =E2=80=94 the RC parameter= s tables (`rc_parameters_pre_scr`) in `drm_dsc_helper.c` have entries for b= pc=3D10, and the rest of `dsi_populate_dsc_params()` is generic with respec= t to bpc. The original commit `b0e71c2637d1` deliberately added 10/12 bpc s= upport. Removing it without a clear bug report or test failure constitutes = a functionality regression. --- Generated by Claude Code Patch Reviewer