From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: setup RC model properly Date: Mon, 09 Mar 2026 09:04:14 +1000 Message-ID: In-Reply-To: <20260306092553.37973-1-mitltlatltl@gmail.com> References: <20260306092553.37973-1-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dsi: setup RC model properly Author: Pengyu Luo Patches: 3 Reviewed: 2026-03-09T09:04:14.370369 --- This is a single patch that improves the DSC (Display Stream Compression) RC model parameter selection in the MSM DSI host driver. The current code unconditionally uses `DRM_DSC_1_1_PRE_SCR` parameters regardless of the DSC version, while this patch adds proper version-based selection to also support DSC 1.2 with 4:2:2, 4:2:0, and 4:4:4 subsampling modes. The change is reasonable and the logic is correct. The commit message honestly notes that incorrect parameters don't visibly affect display, which is good transparency. However, there are a few issues worth raising. --- Generated by Claude Code Patch Reviewer