Claude review: firmware: qcom: Add OP-TEE PAS service support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: firmware: qcom: Add OP-TEE PAS service support
Author: Sumit Garg <sumit.garg@kernel.org>
Patches: 23
Reviewed: 2026-03-09T08:59:07.202306

---

This series introduces a generic Peripheral Authentication Service (PAS) abstraction layer (`qcom_pas`) that sits between Qualcomm firmware client drivers and the actual TrustZone backend (SCM or OP-TEE). The motivation is sound: decoupling client drivers from the specific TZ implementation to support OP-TEE as an alternative to QTEE/SCM. The series is well-structured with clear separation: generic API (patch 2), SCM backend migration (patch 3), TEE backend (patch 4), client driver conversions (patches 5-13), and cleanup (patch 14).

However, the implementation has several architectural issues, primarily around the global singleton `ops_ptr` dispatch pattern which lacks proper synchronization and lifetime management, unsafe type casting between the old and new context structs, and a Kconfig `select` anti-pattern that can cause build failures.

**Key issues:**
1. Race conditions in `ops_ptr` access (no locking, use-after-unregister possible)
2. Kconfig `select QCOM_PAS_TEE` violates dependency rules
3. Unsafe C-style casts between `qcom_scm_pas_context` and `qcom_pas_context`
4. Copy-paste error in TEE driver error messages
5. Return type inconsistency in `get_rsc_table` ops callback

---

---
Generated by Claude Code Patch Reviewer