From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: panel: Document the rotation property
Date: Mon, 09 Mar 2026 08:50:40 +1000 [thread overview]
Message-ID: <review-overall-20260306124808.166776-1-l.scorcia@gmail.com> (raw)
In-Reply-To: <20260306124808.166776-1-l.scorcia@gmail.com>
Overall Series Review
Subject: dt-bindings: display: panel: Document the rotation property
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Patches: 2
Reviewed: 2026-03-09T08:50:40.904203
---
This is a single, straightforward dt-bindings documentation fix. The Jadard jd9365da-h3 panel driver already parses the `rotation` property (via `of_drm_get_panel_orientation()` at line 1408 of `panel-jadard-jd9365da-h3.c`) and exposes it through `get_orientation`, but the YAML binding schema doesn't list `rotation` as an allowed property. This causes `dtbs_check` failures for any devicetree that sets `rotation` on this panel. The fix is correct and well-motivated.
The patch is **v2** and the commit message has been improved per review feedback to explain *why* the property is needed in the binding.
**Verdict: Looks good overall, with one minor formatting issue.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 12:44 [PATCH v2] dt-bindings: display: panel: Document the rotation property Luca Leonardo Scorcia
2026-03-07 15:05 ` Krzysztof Kozlowski
2026-03-08 22:50 ` Claude Code Review Bot [this message]
2026-03-08 22:50 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 18:03 [PATCH v3] " Luca Leonardo Scorcia
2026-03-10 2:03 ` Claude review: " Claude Code Review Bot
2026-03-10 2:03 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306124808.166776-1-l.scorcia@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox