From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Document the rotation property Date: Mon, 09 Mar 2026 08:50:40 +1000 Message-ID: In-Reply-To: <20260306124808.166776-1-l.scorcia@gmail.com> References: <20260306124808.166776-1-l.scorcia@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: dt-bindings: display: panel: Document the rotation property Author: Luca Leonardo Scorcia Patches: 2 Reviewed: 2026-03-09T08:50:40.904203 --- This is a single, straightforward dt-bindings documentation fix. The Jadard jd9365da-h3 panel driver already parses the `rotation` property (via `of_drm_get_panel_orientation()` at line 1408 of `panel-jadard-jd9365da-h3.c`) and exposes it through `get_orientation`, but the YAML binding schema doesn't list `rotation` as an allowed property. This causes `dtbs_check` failures for any devicetree that sets `rotation` on this panel. The fix is correct and well-motivated. The patch is **v2** and the commit message has been improved per review feedback to explain *why* the property is needed in the binding. **Verdict: Looks good overall, with one minor formatting issue.** --- Generated by Claude Code Patch Reviewer