From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau: avoid -Wtautological-constant-out-of-range-compare warning Date: Mon, 09 Mar 2026 08:46:20 +1000 Message-ID: In-Reply-To: <20260306150650.465132-1-arnd@kernel.org> References: <20260306150650.465132-1-arnd@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/nouveau: avoid -Wtautological-constant-out-of-range-compare warning Author: Arnd Bergmann Patches: 1 Reviewed: 2026-03-09T08:46:20.335892 --- This is a single-patch fix from Arnd Bergmann addressing a `-Wtautological-constant-out-of-range-compare` warning (turned into an error with `-Werror`) on 32-bit builds. The approach changes `flush_page_addr` from `dma_addr_t` to `u64` to eliminate comparisons of a 32-bit type against 64-bit `DMA_BIT_MASK(52)` constants. The fix is reasonable and the commit message is well-written with a proper Fixes tag. **Verdict: Acceptable with minor concern noted below.** --- Generated by Claude Code Patch Reviewer