From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Avoid oops on illegal VGA register access
Date: Mon, 09 Mar 2026 08:44:57 +1000 [thread overview]
Message-ID: <review-overall-20260306152413.758919-1-Simon.Richter@hogyros.de> (raw)
In-Reply-To: <20260306152413.758919-1-Simon.Richter@hogyros.de>
Overall Series Review
Subject: Avoid oops on illegal VGA register access
Author: Simon Richter <Simon.Richter@hogyros.de>
Patches: 2
Reviewed: 2026-03-09T08:44:57.272701
---
This is a simple, well-reasoned single-patch series that adds error handling for `vga_get_uninterruptible()` calls in the i915 VGA helper code. The motivation is clear: on non-x86 platforms, VGA legacy I/O resources may not be mappable, and ignoring the error return from `vga_get_uninterruptible()` leads to an oops when subsequent `outb()`/`inb()` calls are reached. The fix correctly skips the VGA I/O port accesses when VGA arbitration fails, while still performing the necessary MMIO register writes (like `VGA_DISP_DISABLE`).
The patch is straightforward, correct, and low-risk. The approach of "if we can't get VGA access, neither can vgacon, so there's nothing to synchronize" is sound logic.
**No major issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 15:23 [PATCH 5.3-6.19 0/1] Avoid oops on illegal VGA register access Simon Richter
2026-03-06 15:23 ` [PATCH 1/1] drm/i915: handle failure from vga_get_uninterruptible() Simon Richter
2026-03-08 22:44 ` Claude review: " Claude Code Review Bot
2026-03-08 22:44 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-17 16:51 [PATCH 0/1] Avoid oops on illegal VGA register access Simon Richter
2026-02-17 20:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306152413.758919-1-Simon.Richter@hogyros.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox