From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Avoid oops on illegal VGA register access Date: Mon, 09 Mar 2026 08:44:57 +1000 Message-ID: In-Reply-To: <20260306152413.758919-1-Simon.Richter@hogyros.de> References: <20260306152413.758919-1-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Avoid oops on illegal VGA register access Author: Simon Richter Patches: 2 Reviewed: 2026-03-09T08:44:57.272701 --- This is a simple, well-reasoned single-patch series that adds error handling for `vga_get_uninterruptible()` calls in the i915 VGA helper code. The motivation is clear: on non-x86 platforms, VGA legacy I/O resources may not be mappable, and ignoring the error return from `vga_get_uninterruptible()` leads to an oops when subsequent `outb()`/`inb()` calls are reached. The fix correctly skips the VGA I/O port accesses when VGA arbitration fails, while still performing the necessary MMIO register writes (like `VGA_DISP_DISABLE`). The patch is straightforward, correct, and low-risk. The approach of "if we can't get VGA access, neither can vgacon, so there's nothing to synchronize" is sound logic. **No major issues found.** --- Generated by Claude Code Patch Reviewer