From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/pagemap_util: Ensure proper cache lock management on free Date: Mon, 09 Mar 2026 08:43:45 +1000 Message-ID: In-Reply-To: <20260306154322.60120-2-jonathan.cavitt@intel.com> References: <20260306154322.60120-2-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/pagemap_util: Ensure proper cache lock management on free Author: Jonathan Cavitt Patches: 1 Reviewed: 2026-03-09T08:43:45.286991 --- This is a single-patch fix for a real bug in `drm_pagemap_cache_fini` where the spinlock `cache->lock` is never released when `dpagemap` is non-NULL but `drm_pagemap_shrinker_cancel()` returns false. The patch simplifies the function into a clean linear flow with a single unlock point. The fix is correct, well-structured, and addresses the bug clearly. **Verdict: Looks good.** --- Generated by Claude Code Patch Reviewer