public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: fix pclk rate calculation for bonded dsi
Date: Mon, 09 Mar 2026 08:39:05 +1000	[thread overview]
Message-ID: <review-overall-20260306163255.215456-1-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260306163255.215456-1-mitltlatltl@gmail.com>

Overall Series Review

Subject: drm/msm/dsi: fix pclk rate calculation for bonded dsi
Author: Pengyu Luo <mitltlatltl@gmail.com>
Patches: 3
Reviewed: 2026-03-09T08:39:05.779362

---

This is a single-patch bug fix for the DSI pixel clock rate calculation when using bonded (dual-link) DSI with Display Stream Compression (DSC). The fix is logically sound: in bonded DSI mode, each link handles half the display width independently, so the DSC-compressed width should be calculated per-link (with per-link rounding) rather than for the full width. The commit message provides a clear numerical example demonstrating the off-by-one difference.

The fix is small, well-scoped, and correctly addresses the rounding discrepancy. It has appropriate `Fixes:` tag.

**Verdict: Good patch, minor nits below.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-08 22:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 16:32 [PATCH] drm/msm/dsi: fix pclk rate calculation for bonded dsi Pengyu Luo
2026-03-06 16:50 ` Dmitry Baryshkov
2026-03-07 19:57 ` kernel test robot
2026-03-08 22:39 ` Claude Code Review Bot [this message]
2026-03-08 22:39 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260306163255.215456-1-mitltlatltl@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox