From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel: ethosu: Add performance counter support
Date: Mon, 09 Mar 2026 08:34:13 +1000 [thread overview]
Message-ID: <review-overall-20260306163658.2741860-2-robh@kernel.org> (raw)
In-Reply-To: <20260306163658.2741860-2-robh@kernel.org>
Overall Series Review
Subject: accel: ethosu: Add performance counter support
Author: "Rob Herring (Arm)" <robh@kernel.org>
Patches: 1
Reviewed: 2026-03-09T08:34:13.070401
---
This is a single patch adding PMU (Performance Monitoring Unit) performance counter support to the Arm Ethos-U NPU accel driver. The design is modeled after V3D's perfmon implementation. The patch adds new ioctls for creating, destroying, querying, and setting global performance monitors, along with hardware register definitions and job integration.
Overall the patch is functional but has several issues ranging from potential bugs, UAPI concerns, and concurrency/locking problems that should be addressed before merging.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 16:36 [PATCH] accel: ethosu: Add performance counter support Rob Herring (Arm)
2026-03-08 22:34 ` Claude review: " Claude Code Review Bot
2026-03-08 22:34 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306163658.2741860-2-robh@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox