From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel: ethosu: Add performance counter support Date: Mon, 09 Mar 2026 08:34:13 +1000 Message-ID: In-Reply-To: <20260306163658.2741860-2-robh@kernel.org> References: <20260306163658.2741860-2-robh@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel: ethosu: Add performance counter support Author: "Rob Herring (Arm)" Patches: 1 Reviewed: 2026-03-09T08:34:13.070401 --- This is a single patch adding PMU (Performance Monitoring Unit) performance counter support to the Arm Ethos-U NPU accel driver. The design is modeled after V3D's perfmon implementation. The patch adds new ioctls for creating, destroying, querying, and setting global performance monitors, along with hardware register definitions and job integration. Overall the patch is functional but has several issues ranging from potential bugs, UAPI concerns, and concurrency/locking problems that should be addressed before merging. --- Generated by Claude Code Patch Reviewer