From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/color: Enable SDR plane color pipeline Date: Mon, 09 Mar 2026 08:26:52 +1000 Message-ID: In-Reply-To: <20260306165307.3233194-1-chaitanya.kumar.borah@intel.com> References: <20260306165307.3233194-1-chaitanya.kumar.borah@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915/color: Enable SDR plane color pipeline Author: Chaitanya Kumar Borah Patches: 11 Reviewed: 2026-03-09T08:26:52.283357 --- This 10-patch series adds SDR plane color pipeline support to i915, introdu= cing a new `DRM_COLOROP_CSC_FF` type in the DRM colorop framework and wirin= g it up along with pre/post-CSC 1D LUTs for SDR planes. The series also inc= ludes a bugfix for HDR pre-CSC LUT programming and refactoring to extract c= ommon HDR LUT programming into helpers. The architecture is sound =E2=80=94 exposing fixed-function CSC as a dedica= ted colorop type rather than overloading the existing CTM is the right appr= oach. However, there are several bugs ranging from a **critical register co= rruption issue** in patch 3 to a **wrong extraction function** in patches 7= /9, and some fragile hardcoded assumptions. **Series ordering concern**: The bugfix (patch 5) with `Cc: stable` and `Fi= xes:` tag should be at the front of the series, not buried after feature pa= tches. It has no dependency on patches 1-4 and should be independently back= portable. --- --- Generated by Claude Code Patch Reviewer