From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: iopoll: fix function parameter names in read_poll_timeout_atomic()
Date: Mon, 09 Mar 2026 08:11:16 +1000 [thread overview]
Message-ID: <review-overall-20260306221033.2357305-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260306221033.2357305-1-rdunlap@infradead.org>
Overall Series Review
Subject: iopoll: fix function parameter names in read_poll_timeout_atomic()
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 1
Reviewed: 2026-03-09T08:11:16.714489
---
This is a single-patch series that fixes kernel-doc warnings for `read_poll_timeout_atomic()` in `include/linux/iopoll.h`. The fix is straightforward and correct: the macro's parameter names (`sleep_us`, `sleep_before_read`) didn't match the kernel-doc comments (`delay_us`, `delay_before_read`), causing kernel-doc warnings. The v2 approach—renaming the parameters to match the documentation rather than the other way around—is the right call, since "delay" is semantically more accurate for an atomic (non-sleeping) context that uses `udelay()` rather than `usleep_range()`.
**Verdict: Patch looks good.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 22:10 [PATCH v2] iopoll: fix function parameter names in read_poll_timeout_atomic() Randy Dunlap
2026-03-08 22:11 ` Claude review: " Claude Code Review Bot
2026-03-08 22:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260306221033.2357305-1-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox