From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Bridges without VGA support Date: Mon, 09 Mar 2026 08:05:36 +1000 Message-ID: In-Reply-To: <20260307173538.763188-1-Simon.Richter@hogyros.de> References: <20260307173538.763188-1-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Bridges without VGA support Author: Simon Richter Patches: 6 Reviewed: 2026-03-09T08:05:36.022574 --- This is a well-motivated 5-patch series that adds proper error propagation for VGA arbitration failures, targeting environments where PCI bridges cannot activate VGA decoding (IBM PowerNV root bridges, GPU passthrough VMs). The series follows a logical progression: first fix error handling, then propagate errors upward, then add `__must_check` annotations, then add the actual hardware readback check, and finally annotate the lower-level function. The series is generally clean and correct, but there are two notable issues: a coding style problem in patch 4, and a subtle semantic concern with `vga_tryget()` masking the real error code after patch 2. --- --- Generated by Claude Code Patch Reviewer