From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ras: Fix memory leak in doit_reply_value() error path
Date: Mon, 09 Mar 2026 08:03:42 +1000 [thread overview]
Message-ID: <review-overall-20260307184541.257941-1-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260307184541.257941-1-shuicheng.lin@intel.com>
Overall Series Review
Subject: drm/ras: Fix memory leak in doit_reply_value() error path
Author: Shuicheng Lin <shuicheng.lin@intel.com>
Patches: 1
Reviewed: 2026-03-09T08:03:42.495830
---
This is a single-patch fix for a memory leak in `doit_reply_value()` in `drivers/gpu/drm/drm_ras.c`. The fix is straightforward, correct, and well-structured. It converts the existing error handling from inline cleanup to a `goto`-based pattern, which is the standard kernel style for shared cleanup paths.
The core bug: when `get_node_error_counter()` fails after `genlmsg_iput()` has succeeded, the `msg` sk_buff is leaked because the old code did a bare `return ret` without freeing it. This is a legitimate bug.
**Verdict: Good patch, should be accepted.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 18:45 [PATCH] drm/ras: Fix memory leak in doit_reply_value() error path Shuicheng Lin
2026-03-08 22:03 ` Claude review: " Claude Code Review Bot
2026-03-08 22:03 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260307184541.257941-1-shuicheng.lin@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox