From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ras: Fix memory leak in doit_reply_value() error path Date: Mon, 09 Mar 2026 08:03:42 +1000 Message-ID: In-Reply-To: <20260307184541.257941-1-shuicheng.lin@intel.com> References: <20260307184541.257941-1-shuicheng.lin@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/ras: Fix memory leak in doit_reply_value() error path Author: Shuicheng Lin Patches: 1 Reviewed: 2026-03-09T08:03:42.495830 --- This is a single-patch fix for a memory leak in `doit_reply_value()` in `drivers/gpu/drm/drm_ras.c`. The fix is straightforward, correct, and well-structured. It converts the existing error handling from inline cleanup to a `goto`-based pattern, which is the standard kernel style for shared cleanup paths. The core bug: when `get_node_error_counter()` fails after `genlmsg_iput()` has succeeded, the `msg` sk_buff is leaked because the old code did a bare `return ret` without freeing it. This is a legitimate bug. **Verdict: Good patch, should be accepted.** --- Generated by Claude Code Patch Reviewer