From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: replace fixed sleeps with read_poll_timeout
Date: Mon, 09 Mar 2026 08:02:33 +1000 [thread overview]
Message-ID: <review-overall-20260307204708.60398-1-iprintercanon@gmail.com> (raw)
In-Reply-To: <20260307204708.60398-1-iprintercanon@gmail.com>
Overall Series Review
Subject: drm/tyr: replace fixed sleeps with read_poll_timeout
Author: Artem Lytkin <iprintercanon@gmail.com>
Patches: 1
Reviewed: 2026-03-09T08:02:33.913687
---
This is a single patch that replaces fixed 100ms sleeps with `read_poll_timeout()` calls in the Tyr (Rust Mali GPU) driver. The change is well-motivated — the TODO comments in the code explicitly asked for this conversion.
**However, this patch is already superseded.** The drm-next tree already contains this exact conversion (the files at `drivers/gpu/drm/tyr/driver.rs` and `drivers/gpu/drm/tyr/gpu.rs` on drm-next already use `poll::read_poll_timeout`). This explains why the patches could not be applied cleanly. The author appears to have developed against an older tree.
Setting aside the already-landed status, the patch is largely correct but has a few minor differences worth noting compared to what actually landed.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 20:47 [PATCH] drm/tyr: replace fixed sleeps with read_poll_timeout Artem Lytkin
2026-03-08 22:02 ` Claude Code Review Bot [this message]
2026-03-08 22:02 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260307204708.60398-1-iprintercanon@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox