From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: replace fixed sleeps with read_poll_timeout Date: Mon, 09 Mar 2026 08:02:33 +1000 Message-ID: In-Reply-To: <20260307204708.60398-1-iprintercanon@gmail.com> References: <20260307204708.60398-1-iprintercanon@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/tyr: replace fixed sleeps with read_poll_timeout Author: Artem Lytkin Patches: 1 Reviewed: 2026-03-09T08:02:33.913687 --- This is a single patch that replaces fixed 100ms sleeps with `read_poll_tim= eout()` calls in the Tyr (Rust Mali GPU) driver. The change is well-motivat= ed =E2=80=94 the TODO comments in the code explicitly asked for this conver= sion. **However, this patch is already superseded.** The drm-next tree already co= ntains this exact conversion (the files at `drivers/gpu/drm/tyr/driver.rs` = and `drivers/gpu/drm/tyr/gpu.rs` on drm-next already use `poll::read_poll_t= imeout`). This explains why the patches could not be applied cleanly. The a= uthor appears to have developed against an older tree. Setting aside the already-landed status, the patch is largely correct but h= as a few minor differences worth noting compared to what actually landed. --- Generated by Claude Code Patch Reviewer