From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: msm: adreno: attempt to recover from ringbuffer drain timeout Date: Mon, 09 Mar 2026 07:37:27 +1000 Message-ID: In-Reply-To: <20260308-adreno-ringbuffer-drain-timeout-recovery-v1-1-985a33faf108@postmarketos.org> References: <20260308-adreno-ringbuffer-drain-timeout-recovery-v1-1-985a33faf108@postmarketos.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: msm: adreno: attempt to recover from ringbuffer drain timeout Author: Paul Sajna Patches: 1 Reviewed: 2026-03-09T07:37:27.592702 --- This is a single patch that attempts to address a 13-year-old TODO in the adreno GPU driver by calling `recover()` when a ringbuffer drain timeout occurs in `adreno_idle()`. While the intent is reasonable, the implementation has **serious problems** that would likely cause kernel crashes, deadlocks, or other undefined behavior. The `recover()` path is designed to be called from `recover_worker()` under specific locking and state management conditions that are not met when calling it directly from `adreno_idle()`. **Not suitable for merging as-is.** The approach needs significant rethinking. --- Generated by Claude Code Patch Reviewer