From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: use drm_gem_ttm_dumb_map_offset()
Date: Mon, 09 Mar 2026 07:52:56 +1000 [thread overview]
Message-ID: <review-overall-20260308-master-v1-1-af32d71c8a1d@gmail.com> (raw)
In-Reply-To: <20260308-master-v1-1-af32d71c8a1d@gmail.com>
Overall Series Review
Subject: drm/loongson: use drm_gem_ttm_dumb_map_offset()
Author: Amin GATTOUT <amin.gattout@gmail.com>
Patches: 1
Reviewed: 2026-03-09T07:52:56.083383
---
This is a clean, straightforward cleanup patch. It replaces the open-coded `lsdc_dumb_map_offset()` in the loongson DRM driver with the existing generic `drm_gem_ttm_dumb_map_offset()` helper from `drm_gem_ttm_helper.c`. The two implementations are **byte-for-byte identical** in logic (lookup GEM object by handle, get vma_node offset, put object, return). The patch correctly removes the now-unnecessary function definition and declaration, and adds the required header include.
**Verdict: Looks good.** No functional issues.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-08 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 10:15 [PATCH] drm/loongson: use drm_gem_ttm_dumb_map_offset() Amin GATTOUT
2026-03-08 21:52 ` Claude review: " Claude Code Review Bot
2026-03-08 21:52 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260308-master-v1-1-af32d71c8a1d@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox