From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Tianma TA066VVHM03 DSI panel Date: Mon, 09 Mar 2026 07:59:02 +1000 Message-ID: In-Reply-To: <20260308-tianma-ta066vvhm03-v1-0-869fac443b20@pm.me> References: <20260308-tianma-ta066vvhm03-v1-0-869fac443b20@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support for Tianma TA066VVHM03 DSI panel Author: Alexander Koskovich Patches: 6 Reviewed: 2026-03-09T07:59:02.650574 --- This is a straightforward 2-patch series adding a new DSI panel driver for = the Tianma TA066VVHM03 AMOLED panel (6.59" 1080x2340 with DSC), found in th= e ASUS ROG Phone 3. The driver was generated with `linux-mdss-dsi-panel-dri= ver-generator`. The series uses modern APIs (`devm_drm_panel_alloc`, `drm_c= onnector_helper_get_modes_fixed`, `mipi_dsi_multi_context`), which is good. However, there are a few issues: 1. **Hard dependency on unmerged `dsc_slice_per_pkt` support** =E2=80=94 th= is series cannot build without that patch being merged first. 2. **Missing error-path cleanup in `prepare`** =E2=80=94 after PPS or compr= ession mode fails, GPIOs and regulators are left enabled. 3. **Binding/driver mismatch for `enable-gpios`** =E2=80=94 the binding mak= es it optional but the driver requires it. --- --- Generated by Claude Code Patch Reviewer