From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Tianma TA066VVHM03 DSI panel Date: Tue, 10 Mar 2026 12:50:30 +1000 Message-ID: In-Reply-To: <20260308-tianma-ta066vvhm03-v2-0-5f2344685133@pm.me> References: <20260308-tianma-ta066vvhm03-v2-0-5f2344685133@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support for Tianma TA066VVHM03 DSI panel Author: Alexander Koskovich Patches: 7 Reviewed: 2026-03-10T12:50:30.758142 --- This is a 2-patch series adding a new DSI panel driver for the Tianma TA066= VVHM03 6.59" AMOLED panel with DSC compression, used in the ASUS ROG Phone = 3. The series is clean and follows modern panel driver patterns (uses `devm= _drm_panel_alloc`, `mipi_dsi_multi_context`, `drm_connector_helper_get_mode= s_fixed`, etc.). The DT binding already has a Reviewed-by from Krzysztof Ko= zlowski. There are a few issues worth addressing: 1. **Dependency on unmerged `dsc_slice_per_pkt` support** =E2=80=94 the cov= er letter acknowledges this, but it means the driver won't compile on mainl= ine. 2. **Missing cleanup in `prepare()` error paths** =E2=80=94 PPS/compression= failures leak regulators and GPIOs. 3. **`enable-gpios` mismatch between binding and driver** =E2=80=94 optiona= l in binding, mandatory in driver probe. 4. **Questionable LPM handling in `_off()`** =E2=80=94 clears LPM before se= nding DCS commands, which is unusual. 5. **Refresh rate of 160 Hz** looks atypical for a phone panel =E2=80=94 ma= y be intentional, but worth confirming. Overall the series is in reasonable shape. The DT binding patch is fine; th= e panel driver needs minor fixes to error handling and consistency. --- Generated by Claude Code Patch Reviewer