From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Split Generic PHY consumer and provider API
Date: Mon, 09 Mar 2026 07:51:39 +1000 [thread overview]
Message-ID: <review-overall-20260308114009.2546587-1-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20260308114009.2546587-1-vladimir.oltean@nxp.com>
Overall Series Review
Subject: Split Generic PHY consumer and provider API
Author: vladimir.oltean@nxp.com
Patches: 29
Reviewed: 2026-03-09T07:51:39.708873
---
This is a well-structured 24-patch series by Vladimir Oltean that splits the Generic PHY framework into separate consumer and provider APIs, hiding `struct phy` internals from consumer drivers. The goal is sound: preventing consumer drivers from poking into PHY internals (power_count, dev.of_node, attrs fields) by making `struct phy` opaque to them. This follows the pattern established by other kernel subsystems (regulator, gpio, iio, etc.).
The series is logically ordered: first fix missing header dependencies (patches 1-7), then fix consumer API violations (patches 8-11), move the provider API (patch 12), add proper accessor helpers (patches 13-14), update remaining consumers to include the provider header or use proper APIs (patches 15-22), remove the compatibility shim (patch 23), and finally improve MAINTAINERS coverage (patch 24).
The approach is generally correct, and the series has already collected several Acked-by/Reviewed-by tags. There are a few points worth discussing, noted below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-08 21:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 11:39 [PATCH v2 phy-next 00/24] Split Generic PHY consumer and provider API vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 01/24] ata: add <linux/pm_runtime.h> where missing vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 02/24] PCI: Add missing headers transitively included by <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 03/24] usb: add " vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 04/24] drm: add <linux/pm_runtime.h> where missing vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 05/24] phy: " vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 06/24] phy: spacemit: include missing <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 07/24] net: lan969x: include missing <linux/of.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 08/24] PCI: Remove device links to PHY vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 09/24] ufs: exynos: stop poking into struct phy guts vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 11/24] drm/msm/dp: remove debugging prints with internal struct phy state vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 12/24] phy: move provider API out of public <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 13/24] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 14/24] phy: introduce phy_get_max_link_rate() helper for consumers vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 15/24] drm/rockchip: dsi: include PHY provider header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 16/24] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 17/24] media: sunxi: a83-mips-csi2: include PHY provider header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 18/24] net: renesas: rswitch: " vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 19/24] pinctrl: tegra-xusb: " vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 20/24] power: supply: cpcap-charger: include missing <linux/property.h> vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 21/24] phy: include PHY provider header (1/2) vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 22/24] phy: include PHY provider header (2/2) vladimir.oltean
2026-03-08 12:01 ` Russell King (Oracle)
2026-03-08 12:37 ` Vladimir Oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 23/24] phy: remove temporary provider compatibility from consumer header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 24/24] MAINTAINERS: add regexes for linux-phy vladimir.oltean
2026-03-08 18:40 ` Joe Perches
[not found] ` <20260308191017.kcyi7ka5pktq5jl4@skbuf>
2026-03-08 19:25 ` Joe Perches
2026-03-08 21:51 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 19:08 [PATCH v3 phy-next 00/24] Split Generic PHY consumer and provider API Vladimir Oltean
2026-03-10 1:57 ` Claude review: " Claude Code Review Bot
2026-03-19 22:32 [PATCH v5 phy-next 00/27] " Vladimir Oltean
2026-03-21 18:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260308114009.2546587-1-vladimir.oltean@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox