From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Split Generic PHY consumer and provider API Date: Mon, 09 Mar 2026 07:51:39 +1000 Message-ID: In-Reply-To: <20260308114009.2546587-1-vladimir.oltean@nxp.com> References: <20260308114009.2546587-1-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Split Generic PHY consumer and provider API Author: vladimir.oltean@nxp.com Patches: 29 Reviewed: 2026-03-09T07:51:39.708873 --- This is a well-structured 24-patch series by Vladimir Oltean that splits the Generic PHY framework into separate consumer and provider APIs, hiding `struct phy` internals from consumer drivers. The goal is sound: preventing consumer drivers from poking into PHY internals (power_count, dev.of_node, attrs fields) by making `struct phy` opaque to them. This follows the pattern established by other kernel subsystems (regulator, gpio, iio, etc.). The series is logically ordered: first fix missing header dependencies (patches 1-7), then fix consumer API violations (patches 8-11), move the provider API (patch 12), add proper accessor helpers (patches 13-14), update remaining consumers to include the provider header or use proper APIs (patches 15-22), remove the compatibility shim (patch 23), and finally improve MAINTAINERS coverage (patch 24). The approach is generally correct, and the series has already collected several Acked-by/Reviewed-by tags. There are a few points worth discussing, noted below. --- Generated by Claude Code Patch Reviewer