public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: 2 bugfixes found in DRM-CI
Date: Tue, 10 Mar 2026 12:46:56 +1000	[thread overview]
Message-ID: <review-overall-20260308223538.96729-1-jim.cromie@gmail.com> (raw)
In-Reply-To: <20260308223538.96729-1-jim.cromie@gmail.com>

Overall Series Review

Subject: 2 bugfixes found in DRM-CI
Author: Jim Cromie <jim.cromie@gmail.com>
Patches: 3
Reviewed: 2026-03-10T12:46:56.389302

---

This is a 2-patch bugfix series from Jim Cromie addressing issues found in DRM-CI. Both patches fix real bugs:

1. **Patch 1** fixes a 64-bit truncation bug in `drm_buddy.c` where `roundup_pow_of_two()` / `rounddown_pow_of_two()` use `unsigned long` internally, which truncates `u64` values on 32-bit architectures.

2. **Patch 2** fixes a debug message flood in `drm_print.c` where `__drm_printfn_dbg()` uses the dyndbg-optimized `__drm_debug_enabled()` (which evaluates to `true` under `CONFIG_DRM_USE_DYNAMIC_DEBUG=Y`) instead of performing the actual bitmask check.

Both are legitimate fixes with clear problem descriptions. However, each patch has issues worth discussing.

Note: The kernel tree at `linux/` has been significantly refactored (drm_buddy → gpu_buddy), so the patches don't apply. The review is based on the patch content and the original code as visible from the diff context.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-10  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 22:35 [PATCH 0/2] 2 bugfixes found in DRM-CI Jim Cromie
2026-03-08 22:35 ` [PATCH 1/2] drm_buddy: fix power-of-2 rounding errs Jim Cromie
2026-03-10  2:46   ` Claude review: " Claude Code Review Bot
2026-03-08 22:35 ` [PATCH 2/2] drivers/gpu/drm/drm_print: fix drm_printer dynamic debug bypass Jim Cromie
2026-03-10  2:46   ` Claude review: " Claude Code Review Bot
2026-03-10  2:46 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260308223538.96729-1-jim.cromie@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox