From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: update `kernel::c_str!` documentation
Date: Tue, 10 Mar 2026 12:05:04 +1000 [thread overview]
Message-ID: <review-overall-20260309-cstr-rename-macro-v2-1-25f7de75944e@kernel.org> (raw)
In-Reply-To: <20260309-cstr-rename-macro-v2-1-25f7de75944e@kernel.org>
Overall Series Review
Subject: rust: update `kernel::c_str!` documentation
Author: Tamir Duberstein <tamird@kernel.org>
Patches: 1
Reviewed: 2026-03-10T12:05:04.277925
---
This is a single, straightforward documentation-only patch. It updates the `kernel::c_str!` macro documentation to reflect that Rust now has native C string literals (`c"..."` since Rust 1.77), and that the macro's primary remaining use case is for non-literal compile-time C strings (e.g., inside other macros using `concat!`). The patch is well-motivated, clearly written, and already carries reviews from Alice Ryhl and an ack from Greg KH.
No functional code changes are made. The patch looks correct and ready to merge.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-10 2:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 17:01 [PATCH v2] rust: update `kernel::c_str!` documentation Tamir Duberstein
2026-03-10 2:05 ` Claude review: " Claude Code Review Bot
2026-03-10 2:05 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260309-cstr-rename-macro-v2-1-25f7de75944e@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox