From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: it6505: disable HDCP retry when KSV list timeout
Date: Tue, 10 Mar 2026 12:28:47 +1000 [thread overview]
Message-ID: <review-overall-20260309-disable-hdcp-auto-retry-v1-1-591a1d75a3a6@ite.com.tw> (raw)
In-Reply-To: <20260309-disable-hdcp-auto-retry-v1-1-591a1d75a3a6@ite.com.tw>
Overall Series Review
Subject: drm/bridge: it6505: disable HDCP retry when KSV list timeout
Author: Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org>
Patches: 1
Reviewed: 2026-03-10T12:28:47.941159
---
This is a single, straightforward patch that fixes a real user-visible problem (continuous flickering) caused by the IT6505 bridge driver endlessly retrying HDCP authentication when KSV list times out or HDCP fails with certain DP-to-HDMI converters. The fix is simple: replace `it6505_start_hdcp()` with `it6505_stop_hdcp()` in two error paths, breaking the re-authentication loop.
The change is small, well-scoped, and the commit message clearly explains both the problem and the fix. The approach is reasonable — when HDCP cannot succeed (due to a problematic downstream converter), stopping gracefully is better than retrying indefinitely.
**Verdict: Looks good overall, with one concern worth discussing.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 9:47 [PATCH RESEND] drm/bridge: it6505: disable HDCP retry when KSV list timeout Hermes Wu via B4 Relay
2026-03-10 2:28 ` Claude Code Review Bot [this message]
2026-03-10 2:28 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260309-disable-hdcp-auto-retry-v1-1-591a1d75a3a6@ite.com.tw \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox