Claude review: Some updates over DP AUX Transactions

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Some updates over DP AUX Transactions
Author: Arun R Murthy <arun.r.murthy@intel.com>
Patches: 6
Reviewed: 2026-03-10T12:41:15.829415

---

This RFC series attempts to address DP AUX transaction timeouts by (1) adding a helper to wake a sleeping sink, (2) calling it on timeout, and (3) refactoring `get_aux_send_ctl` from returning a value to directly programming the register via RMW. The series has several significant issues:

- **Patch 1** has a misuse of `poll_timeout_us` (using `ret` for two purposes simultaneously) and questionable wake logic.
- **Patch 2** is reasonable in intent but the wake call inside the retry loop may cause excessive delays.
- **Patch 3** is the most problematic: it fundamentally changes the `get_aux_send_ctl` abstraction from a pure value-returning function to one with side effects (writing to hardware registers), and the PSR changes are broken.

The stated motivation of avoiding touching the AUX power request bit (bit 19) is valid, but the approach is overly invasive and introduces multiple bugs. A simpler approach would be to keep the existing abstraction and just mask off / preserve the power request bit in the caller.

---

---
Generated by Claude Code Patch Reviewer