From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Fixes the stack overflow Date: Tue, 10 Mar 2026 12:10:28 +1000 Message-ID: In-Reply-To: <20260309-drm-rust-next-v4-0-4ef485b19a4c@proton.me> References: <20260309-drm-rust-next-v4-0-4ef485b19a4c@proton.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Fixes the stack overflow Author: Tim Kovalenko via B4 Relay Patches: 10 Reviewed: 2026-03-10T12:10:28.120237 --- This is a well-structured 4-patch series that fixes a stack overflow in the nova-core GSP memory allocation path. Patches 1-3 (by Gary Guo) establish generic Rust pointer projection infrastructure in the kernel, and patch 4 (by Tim Kovalenko) uses that infrastructure to fix the actual bug by writing page table entries one-by-one to DMA memory instead of building a large array on the stack. The projection infrastructure is carefully designed with guards against `Deref` unsoundness and misaligned field access. The `dma_read!`/`dma_write!` macro API improvements in patch 3 are a welcome cleanup, making the separation between DMA allocation and projection explicit and enabling both fallible and infallible indexing. Patches 1-3 already carry Reviewed-by from Benno Lossin and Acked-by from Miguel Ojeda, indicating thorough upstream review. The main area needing attention is patch 4, which has some inconsistencies in how it applies the new infrastructure. --- Generated by Claude Code Patch Reviewer