public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Fix deadlock in soft reset sequence
Date: Tue, 10 Mar 2026 12:12:14 +1000	[thread overview]
Message-ID: <review-overall-20260309-fix-soft-reset-v1-1-121113be554f@imgtec.com> (raw)
In-Reply-To: <20260309-fix-soft-reset-v1-1-121113be554f@imgtec.com>

Overall Series Review

Subject: drm/imagination: Fix deadlock in soft reset sequence
Author: Alessio Belle <alessio.belle@imgtec.com>
Patches: 1
Reviewed: 2026-03-10T12:12:14.321041

---

This is a single-patch fix for a real deadlock in the PowerVR (Imagination) DRM driver. The analysis is sound: `pvr_power_reset(pvr_dev, false)` (soft reset) is called from `process_fwccb_command()` → `pvr_fwccb_process()` → `pvr_device_irq_thread_handler()`, which is the threaded IRQ handler. Calling `disable_irq()` from within that handler will deadlock because `disable_irq()` waits (via `synchronize_irq()`) for any running threaded handler to complete — i.e., it waits for itself.

The fix is correct and minimal: use `disable_irq_nosync()` for the soft reset path, which disables the IRQ without waiting for the current handler to finish. This is safe because we are *already inside* the only handler that could be running.

The patch is well-tagged with `Fixes:` and `Cc: stable`, appropriate for a deadlock fix.

**Verdict: This patch looks good and is ready to merge.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  2:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 15:23 [PATCH] drm/imagination: Fix deadlock in soft reset sequence Alessio Belle
2026-03-10  2:12 ` Claude Code Review Bot [this message]
2026-03-10  2:12 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260309-fix-soft-reset-v1-1-121113be554f@imgtec.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox