From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm/tests: add a test to exercise ttm_bo_swapout
Date: Tue, 10 Mar 2026 12:02:40 +1000 [thread overview]
Message-ID: <review-overall-20260309-ttm_bo_swapout_test-v2-1-219f64046cfe@igalia.com> (raw)
In-Reply-To: <20260309-ttm_bo_swapout_test-v2-1-219f64046cfe@igalia.com>
Overall Series Review
Subject: drm/ttm/tests: add a test to exercise ttm_bo_swapout
Author: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Patches: 1
Reviewed: 2026-03-10T12:02:40.219911
---
This is a single-patch series that adds a KUnit test for `ttm_bo_swapout`. The motivation is sound: the function lost test coverage when the previous test was removed (commit 76689eb52667) due to reliability issues with allocating half of system memory. The new approach of directly calling `ttm_bo_swapout` on a single BO avoids that problem entirely and also detected a real UAF bug. The patch is clean, well-structured, and follows the existing test patterns in the file.
The patch looks **good and ready to merge**, with only minor observations below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 18:47 [PATCH v2] drm/ttm/tests: add a test to exercise ttm_bo_swapout Thadeu Lima de Souza Cascardo
2026-03-10 2:02 ` Claude Code Review Bot [this message]
2026-03-10 2:02 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 18:00 [PATCH] " Thadeu Lima de Souza Cascardo
2026-03-08 22:23 ` Claude review: " Claude Code Review Bot
2026-03-08 22:23 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260309-ttm_bo_swapout_test-v2-1-219f64046cfe@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox