Claude review: Add ITE IT6162 MIPI DSI to HDMI bridge driver

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add ITE IT6162 MIPI DSI to HDMI bridge driver
Author: Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org>
Patches: 6
Reviewed: 2026-03-10T12:31:49.636104

---

This is a v2 series adding support for the ITE IT6162 MIPI DSI to HDMI 2.0 bridge chip, consisting of a dt-bindings patch and a driver patch. The driver uses a firmware-controlled MCU on the bridge chip, communicating via an "infoblock" register protocol over I2C. While the overall structure is reasonable, there are several significant bugs and design issues that need to be addressed before this can be merged:

1. **Critical use-before-initialization bug** in `it6162_attach_dsi()` — `dsi` is used before it is assigned.
2. **Missing `DRM_BRIDGE_OP_HDMI` flag** — the driver implements HDMI bridge funcs (infoframes, TMDS rate validation) but never sets the required ops flag.
3. **Missing `DRM_BRIDGE_OP_HPD` flag** — the driver calls `drm_bridge_hpd_notify()` but doesn't advertise HPD support.
4. **Regulator disable ordering** is wrong (should be reverse of enable order).
5. **Sample width mapping is swapped** — 24-bit is mapped to 18-bit and 20-bit to 24-bit.
6. Several lesser issues around error handling, the DT binding, and code style.

---

---
Generated by Claude Code Patch Reviewer