From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add ITE IT6162 MIPI DSI to HDMI bridge driver Date: Tue, 10 Mar 2026 12:31:49 +1000 Message-ID: In-Reply-To: <20260309-upstream-6162-v2-0-debdb6c88030@ite.com.tw> References: <20260309-upstream-6162-v2-0-debdb6c88030@ite.com.tw> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add ITE IT6162 MIPI DSI to HDMI bridge driver Author: Hermes Wu via B4 Relay Patches: 6 Reviewed: 2026-03-10T12:31:49.636104 --- This is a v2 series adding support for the ITE IT6162 MIPI DSI to HDMI 2.0 = bridge chip, consisting of a dt-bindings patch and a driver patch. The driv= er uses a firmware-controlled MCU on the bridge chip, communicating via an = "infoblock" register protocol over I2C. While the overall structure is reas= onable, there are several significant bugs and design issues that need to b= e addressed before this can be merged: 1. **Critical use-before-initialization bug** in `it6162_attach_dsi()` =E2= =80=94 `dsi` is used before it is assigned. 2. **Missing `DRM_BRIDGE_OP_HDMI` flag** =E2=80=94 the driver implements HD= MI bridge funcs (infoframes, TMDS rate validation) but never sets the requi= red ops flag. 3. **Missing `DRM_BRIDGE_OP_HPD` flag** =E2=80=94 the driver calls `drm_bri= dge_hpd_notify()` but doesn't advertise HPD support. 4. **Regulator disable ordering** is wrong (should be reverse of enable ord= er). 5. **Sample width mapping is swapped** =E2=80=94 24-bit is mapped to 18-bit= and 20-bit to 24-bit. 6. Several lesser issues around error handling, the DT binding, and code st= yle. --- --- Generated by Claude Code Patch Reviewer