From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: add hardware cursor support Date: Tue, 10 Mar 2026 12:36:01 +1000 Message-ID: In-Reply-To: <20260309085302.3132732-1-zhengxingda@iscas.ac.cn> References: <20260309085302.3132732-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: verisilicon: add hardware cursor support Author: Icenowy Zheng Patches: 3 Reviewed: 2026-03-10T12:36:01.366419 --- This 2-patch series adds hardware cursor plane support to the Verisilicon display controller driver. Patch 1 extends the HWDB with a max cursor size field, and Patch 2 implements the cursor plane itself. The structure follows the existing primary plane pattern in the driver well. However, there are **two bugs** in the register programming of the cursor plane that will cause incorrect behavior for negative cursor coordinates, plus off-by-one errors in the coordinate range checks. There are also minor style and cosmetic issues. --- Generated by Claude Code Patch Reviewer