public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: add the missing parameter description
Date: Tue, 10 Mar 2026 12:27:21 +1000	[thread overview]
Message-ID: <review-overall-20260309100254.877801-1-mitltlatltl@gmail.com> (raw)
In-Reply-To: <20260309100254.877801-1-mitltlatltl@gmail.com>

Overall Series Review

Subject: drm/msm/dsi: add the missing parameter description
Author: Pengyu Luo <mitltlatltl@gmail.com>
Patches: 1
Reviewed: 2026-03-10T12:27:21.024699

---

This is a single trivial documentation patch that adds a missing `@is_bonded_dsi` kernel-doc parameter description to the `dsi_adjust_pclk_for_compression()` function. The patch was prompted by a kernel test robot (kbuild bot) warning.

**However, the patch appears to be incorrect.** Looking at the actual function signature after the patch is applied (line 588-589 of `dsi_host.c`):

```c
static unsigned long dsi_adjust_pclk_for_compression(const struct drm_display_mode *mode,
		const struct drm_dsc_config *dsc)
```

The function only takes two parameters: `mode` and `dsc`. There is **no** `is_bonded_dsi` parameter on this function. The `is_bonded_dsi` parameter exists on the *caller* function `dsi_host_get_pclk_rate()` (used at line 615), not on `dsi_adjust_pclk_for_compression()`.

Adding a `@is_bonded_dsi` doc entry to the kernel-doc for `dsi_adjust_pclk_for_compression()` will **not** fix the warning — it will create a *new* warning about a documented parameter that doesn't exist in the function signature, while doing nothing about whatever the original kbuild warning actually was.

The referenced Fixes commit `e4eb11b34d6c ("drm/msm/dsi: fix pclk rate calculation for bonded dsi")` likely added `is_bonded_dsi` to `dsi_host_get_pclk_rate()` or similar, and the kbuild warning is probably about that function's kernel-doc, not `dsi_adjust_pclk_for_compression()`.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-10  2:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 10:02 [PATCH] drm/msm/dsi: add the missing parameter description Pengyu Luo
2026-03-10  2:27 ` Claude review: " Claude Code Review Bot
2026-03-10  2:27 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260309100254.877801-1-mitltlatltl@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox