From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dsi: add the missing parameter description Date: Tue, 10 Mar 2026 12:27:21 +1000 Message-ID: In-Reply-To: <20260309100254.877801-1-mitltlatltl@gmail.com> References: <20260309100254.877801-1-mitltlatltl@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/dsi: add the missing parameter description Author: Pengyu Luo Patches: 1 Reviewed: 2026-03-10T12:27:21.024699 --- This is a single trivial documentation patch that adds a missing `@is_bonde= d_dsi` kernel-doc parameter description to the `dsi_adjust_pclk_for_compres= sion()` function. The patch was prompted by a kernel test robot (kbuild bot= ) warning. **However, the patch appears to be incorrect.** Looking at the actual funct= ion signature after the patch is applied (line 588-589 of `dsi_host.c`): ```c static unsigned long dsi_adjust_pclk_for_compression(const struct drm_displ= ay_mode *mode, const struct drm_dsc_config *dsc) ``` The function only takes two parameters: `mode` and `dsc`. There is **no** `= is_bonded_dsi` parameter on this function. The `is_bonded_dsi` parameter ex= ists on the *caller* function `dsi_host_get_pclk_rate()` (used at line 615)= , not on `dsi_adjust_pclk_for_compression()`. Adding a `@is_bonded_dsi` doc entry to the kernel-doc for `dsi_adjust_pclk_= for_compression()` will **not** fix the warning =E2=80=94 it will create a = *new* warning about a documented parameter that doesn't exist in the functi= on signature, while doing nothing about whatever the original kbuild warnin= g actually was. The referenced Fixes commit `e4eb11b34d6c ("drm/msm/dsi: fix pclk rate calc= ulation for bonded dsi")` likely added `is_bonded_dsi` to `dsi_host_get_pcl= k_rate()` or similar, and the kbuild warning is probably about that functio= n's kernel-doc, not `dsi_adjust_pclk_for_compression()`. --- Generated by Claude Code Patch Reviewer