From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sun4i: layers: Use drm_fb_dma_get_gem_addr() to get display memory
Date: Tue, 10 Mar 2026 12:07:04 +1000 [thread overview]
Message-ID: <review-overall-20260309165635.1138413-1-wens@kernel.org> (raw)
In-Reply-To: <20260309165635.1138413-1-wens@kernel.org>
Overall Series Review
Subject: drm/sun4i: layers: Use drm_fb_dma_get_gem_addr() to get display memory
Author: Chen-Yu Tsai <wens@kernel.org>
Patches: 2
Reviewed: 2026-03-10T12:07:04.340955
---
This is a single-patch cleanup that replaces open-coded DMA address calculations in the sun4i UI and VI layer drivers with the existing `drm_fb_dma_get_gem_addr()` helper. The change is straightforward, reduces code duplication, and the helper's logic matches the replaced code. **Looks good overall, with one minor behavioral subtlety worth noting.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 16:56 [PATCH] drm/sun4i: layers: Use drm_fb_dma_get_gem_addr() to get display memory Chen-Yu Tsai
2026-03-09 17:57 ` Jernej Škrabec
2026-03-10 2:07 ` Claude Code Review Bot [this message]
2026-03-10 2:07 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260309165635.1138413-1-wens@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox