Claude review: Split Generic PHY consumer and provider API

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Split Generic PHY consumer and provider API
Author: Vladimir Oltean <vladimir.oltean@nxp.com>
Patches: 25
Reviewed: 2026-03-10T11:57:14.385752

---

This is a well-structured 24-patch series by Vladimir Oltean that splits the Generic PHY subsystem's `<linux/phy/phy.h>` header into separate consumer and provider APIs. The motivation is sound: consumer drivers should not have access to `struct phy` internals (like `power_count`, `init_count`, `dev.of_node`), following the precedent set by other subsystems (gpio, regulator, iio, etc.).

The series follows a clean progression:
1. **Patches 1-7**: Add missing transitive headers that will no longer be provided by `<linux/phy/phy.h>`
2. **Patches 8-11**: Remove consumer driver abuse of `struct phy` internals
3. **Patch 12**: The core split — move provider API to `drivers/phy/phy-provider.h`, create `phy-props.h` for shared types
4. **Patches 13-14**: Make attribute accessors NULL-tolerant and add `phy_get_max_link_rate()`
5. **Patches 15-20**: Fix remaining out-of-tree provider includes and miscellaneous
6. **Patches 21-22**: Mass update of all PHY provider drivers to include new header
7. **Patch 23**: Remove the temporary compatibility `#include` that re-exported provider definitions to consumers
8. **Patch 24**: Add MAINTAINERS regexes

The approach is methodical and the patch ordering is logical. The series has already gathered several Acked-by/Reviewed-by tags from subsystem maintainers. The temporary compatibility shim in patch 12 (including `phy-provider.h` from `phy.h`) that gets removed in patch 23 is a clean bisectability strategy.

**Overall: This is a high-quality series that I would recommend for merging with minor observations noted below.**

---
Generated by Claude Code Patch Reviewer