From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Split Generic PHY consumer and provider API Date: Tue, 10 Mar 2026 11:57:14 +1000 Message-ID: In-Reply-To: <20260309190842.927634-1-vladimir.oltean@nxp.com> References: <20260309190842.927634-1-vladimir.oltean@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Split Generic PHY consumer and provider API Author: Vladimir Oltean Patches: 25 Reviewed: 2026-03-10T11:57:14.385752 --- This is a well-structured 24-patch series by Vladimir Oltean that splits th= e Generic PHY subsystem's `` header into separate consumer= and provider APIs. The motivation is sound: consumer drivers should not ha= ve access to `struct phy` internals (like `power_count`, `init_count`, `dev= .of_node`), following the precedent set by other subsystems (gpio, regulato= r, iio, etc.). The series follows a clean progression: 1. **Patches 1-7**: Add missing transitive headers that will no longer be p= rovided by `` 2. **Patches 8-11**: Remove consumer driver abuse of `struct phy` internals 3. **Patch 12**: The core split =E2=80=94 move provider API to `drivers/phy= /phy-provider.h`, create `phy-props.h` for shared types 4. **Patches 13-14**: Make attribute accessors NULL-tolerant and add `phy_g= et_max_link_rate()` 5. **Patches 15-20**: Fix remaining out-of-tree provider includes and misce= llaneous 6. **Patches 21-22**: Mass update of all PHY provider drivers to include ne= w header 7. **Patch 23**: Remove the temporary compatibility `#include` that re-expo= rted provider definitions to consumers 8. **Patch 24**: Add MAINTAINERS regexes The approach is methodical and the patch ordering is logical. The series ha= s already gathered several Acked-by/Reviewed-by tags from subsystem maintai= ners. The temporary compatibility shim in patch 12 (including `phy-provider= .h` from `phy.h`) that gets removed in patch 23 is a clean bisectability st= rategy. **Overall: This is a high-quality series that I would recommend for merging= with minor observations noted below.** --- Generated by Claude Code Patch Reviewer