From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add locking to Cmdq Date: Wed, 11 Mar 2026 13:32:09 +1000 Message-ID: In-Reply-To: <20260310-cmdq-locking-v4-0-4e5c4753c408@nvidia.com> References: <20260310-cmdq-locking-v4-0-4e5c4753c408@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: gsp: add locking to Cmdq Author: Eliot Courtney Patches: 6 Reviewed: 2026-03-11T13:32:09.489388 --- This is a well-structured 5-patch series that incrementally adds mutex locking to the `Cmdq` (command queue) in the nova-core GSP driver. The series follows a clean decomposition: (1) fix doc comments, (2) extract a timeout constant, (3) add reply/no-reply type infrastructure, (4) make `Cmdq` pinned, (5) add the mutex. The progression is logical, each patch builds on the prior ones, and the final result is clean. The series is already at v4 and has Reviewed-by/Tested-by tags from Zhi Wang and Gary Guo on several patches. The approach of using an associated `Reply` type on `CommandToGsp` to distinguish reply-expecting vs fire-and-forget commands is a good Rust-idiomatic design choice. The locking strategy of holding the mutex over both send and receive in `send_command` is correct for ensuring reply ordering. Overall this looks ready to merge with only minor observations below. --- Generated by Claude Code Patch Reviewer