From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Drain interrupts before suspending the GPU
Date: Wed, 11 Mar 2026 13:25:23 +1000 [thread overview]
Message-ID: <review-overall-20260310-drain-irqs-before-suspend-v1-0-bf4f9ed68e75@imgtec.com> (raw)
In-Reply-To: <20260310-drain-irqs-before-suspend-v1-0-bf4f9ed68e75@imgtec.com>
Overall Series Review
Subject: drm/imagination: Drain interrupts before suspending the GPU
Author: Alessio Belle <alessio.belle@imgtec.com>
Patches: 3
Reviewed: 2026-03-11T13:25:23.778248
---
This is a well-structured 2-patch series fixing a real crash where the GPU threaded IRQ handler can race with runtime PM suspend, accessing GPU registers after the GPU is powered off. The crash signature (SError on ARM64 in `pvr_riscv_irq_pending`) clearly demonstrates the problem. The fix is sound: patch 1 adds `synchronize_irq()` as a minimal stable-backportable fix, and patch 2 strengthens it to `disable_irq()` for a more robust approach. The series is correctly split for stable backporting purposes.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-11 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 11:41 [PATCH 0/2] drm/imagination: Drain interrupts before suspending the GPU Alessio Belle
2026-03-10 11:41 ` [PATCH 1/2] drm/imagination: Synchronize " Alessio Belle
2026-03-11 3:25 ` Claude review: " Claude Code Review Bot
2026-03-10 11:41 ` [PATCH 2/2] drm/imagination: Disable " Alessio Belle
2026-03-11 3:25 ` Claude review: " Claude Code Review Bot
2026-03-11 3:25 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260310-drain-irqs-before-suspend-v1-0-bf4f9ed68e75@imgtec.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox