From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: Rework initial state allocation Date: Wed, 11 Mar 2026 13:09:06 +1000 Message-ID: In-Reply-To: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: Rework initial state allocation Author: Maxime Ripard Patches: 15 Reviewed: 2026-03-11T13:09:06.423249 --- This is a well-structured 14-patch series from Maxime Ripard that introduces `atomic_create_state` callbacks for planes, CRTCs, and connectors (mirroring the existing pattern for `drm_private_obj`), creates a new `drm_mode_config_create_state()` helper, and hooks it into `drm_dev_register()` to automatically initialize all object states. The goal is to cleanly separate initial state allocation from the overloaded `reset()` callback, which conflates initialization, state creation, and hardware reset. The overall design is sound and addresses a real problem. However, there are a few issues worth noting, most importantly a **missing `drm_connector_list_iter_end()` on the error path** in `drm_mode_config_create_state()`, a **potential NULL dereference in `drm_atomic_private_obj_fini()`** after patch 10 removes the eager state allocation, and some questions about the ordering guarantee between private obj creation and `drm_dev_register()`. --- --- Generated by Claude Code Patch Reviewer