From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Rockchip DRM use-after-free & null-ptr-deref fixes
Date: Tue, 10 Mar 2026 11:47:00 +1000 [thread overview]
Message-ID: <review-overall-20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> (raw)
In-Reply-To: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com>
Overall Series Review
Subject: Rockchip DRM use-after-free & null-ptr-deref fixes
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Patches: 9
Reviewed: 2026-03-10T11:47:00.922269
---
This is a well-structured 8-patch series fixing real use-after-free and null-ptr-deref bugs in Rockchip DRM drivers (inno-hdmi, dw_dp, dw_hdmi_qp) and the DW DP bridge library. The first three patches are genuine fixes with appropriate `Fixes:` tags, patches 4-6 are minor cleanups/improvements, and patches 7-8 address issues in the bridge-level dw-dp code.
The core insight is correct: when a component driver uses `devm_kzalloc()` for a structure that embeds a `drm_encoder` initialized via `drmm_encoder_init()`, the devm teardown (during component unbind) frees the memory before the drm-managed cleanup runs (during `drm_dev_put()`), causing use-after-free. Switching to `drmm_kzalloc()` aligns the lifetime of the allocation with the DRM device.
The series looks good overall and should be safe to merge.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-10 1:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 22:44 [PATCH v2 0/8] Rockchip DRM use-after-free & null-ptr-deref fixes Cristian Ciocaltea
2026-03-09 22:44 ` [PATCH v2 1/8] drm/rockchip: inno-hdmi: Switch to drmm_kzalloc() Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 2/8] drm/rockchip: dw_dp: " Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 3/8] drm/rockchip: dw_dp: Fix null-ptr-deref in dw_dp_remove() Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 4/8] drm/rockchip: dw_dp: Simplify error handling Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 5/8] drm/rockchip: dw_dp: Drop unnecessary #include Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 6/8] drm/rockchip: dw_hdmi_qp: Switch to drmm_encoder_init() Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 7/8] drm/bridge: synopsys: dw-dp: Unregister AUX channel on bridge detach Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-09 22:44 ` [PATCH v2 8/8] drm/bridge: synopsys: dw-dp: Drop useless memory allocation Cristian Ciocaltea
2026-03-10 1:47 ` Claude review: " Claude Code Review Bot
2026-03-10 1:47 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox