From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Qualcomm Sahara protocol enhancements. Date: Wed, 11 Mar 2026 13:35:22 +1000 Message-ID: In-Reply-To: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> References: <20260310-sahara_protocol_new_v2-v3-0-994ea4b0d5ad@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Qualcomm Sahara protocol enhancements. Author: Kishore Batta Patches: 10 Reviewed: 2026-03-11T13:35:22.071531 --- This 9-patch series relocates the Sahara protocol driver from the QAIC acce= lerator subsystem to `drivers/bus/mhi/`, makes it a standalone MHI protocol= driver, generalizes device matching via a variant table, adds QDU100 suppo= rt, and introduces command-mode DDR training data capture and sysfs exposur= e. The overall direction is reasonable =E2=80=94 the Sahara protocol is MHI-tr= ansport-level and shouldn't be QAIC-specific. However, there are several is= sues ranging from bugs to design concerns, particularly in the command-mode= handling (patch 7) which is the most complex and risk-prone patch. --- --- Generated by Claude Code Patch Reviewer