public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver
Date: Tue, 10 Mar 2026 11:39:06 +1000	[thread overview]
Message-ID: <review-overall-20260310012458.169272-1-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260310012458.169272-1-damon.ding@rock-chips.com>

Overall Series Review

Subject: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver
Author: Damon Ding <damon.ding@rock-chips.com>
Patches: 14
Reviewed: 2026-03-10T11:39:06.394629

---

This is a well-structured v10 series that modernizes the Analogix DP bridge driver by migrating from a private `drm_connector` to the `drm_bridge_connector` and `panel_bridge` helpers. The series has been through extensive iteration and has accumulated substantial review/test tags (Reviewed-by from Dmitry Baryshkov and Luca Ceresoli, Tested-by from Marek Szyprowski and Heiko Stuebner).

The decomposition into 18 patches is logical - first adding the `next_bridge` plat_data field, then moving the legacy bridge for multi-platform use, cleaning up unused fields and callbacks, migrating to bridge_connector, and finally consolidating the panel/bridge parsing into `analogix_dp_finish_probe()`.

**Key concerns:**
1. A bug in exynos_dp.c where `next_bridge` gets clobbered after being set from the display-mode bridge fallback.
2. The `analogix_dp_start_crc`/`stop_crc` bridge type check is fragile.
3. The `analogix_dp_unbind()` still calls `analogix_dp_bridge_disable()` and `drm_panel_unprepare()` which may conflict with the bridge_connector framework's teardown sequence.

**Note:** The mbox file is truncated and only includes patches 1-13 of 18. Patches 14-18 (applying `analogix_dp_finish_probe()` on Rockchip/Exynos, attaching next bridge in analogix_dp_bridge_attach, removing bridge disabling/panel unpreparing in unbind, and applying panel_bridge helper) are not available for full review. The review below covers the 13 available patches plus observations from the final applied state.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-10  1:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  1:24 [PATCH v10 00/18] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-03-10  1:24 ` [PATCH v10 01/18] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.next_bridge Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 02/18] drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 03/18] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 04/18] drm/exynos: exynos_dp: Remove unused &exynos_dp_device.connector Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 05/18] drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 06/18] drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 07/18] drm/bridge: analogix_dp: Move the color format check to .atomic_check() for Rockchip platforms Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 08/18] drm/bridge: analogix_dp: Remove unused &analogix_dp_plat_data.get_modes() Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 09/18] drm/bridge: analogix_dp: Remove unused struct drm_connector* for &analogix_dp_plat_data.attach() Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 10/18] drm/bridge: analogix_dp: Pass struct drm_atomic_state* for analogix_dp_bridge_mode_set() Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 11/18] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 12/18] drm/bridge: analogix_dp: Remove unnecessary &analogix_dp_device.connector Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:24 ` [PATCH v10 13/18] drm/bridge: analogix_dp: Add new API analogix_dp_finish_probe() Damon Ding
2026-03-10  1:39   ` Claude review: " Claude Code Review Bot
2026-03-10  1:39 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-03-19  7:14 [PATCH v11 00/17] Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Damon Ding
2026-03-21 18:35 ` Claude review: " Claude Code Review Bot
2026-02-10  7:12 [PATCH v9 00/15] " Damon Ding
2026-02-11  6:37 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260310012458.169272-1-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox